[fix] refine site url determination logic#128
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
InayaY3
left a comment
InayaY3
left a comment
There was a problem hiding this comment.
still doesn't work on the previews for me, but at least it doesn't redirect to the local link anymore. ik this was intended to fix for local testing + production testing, so i'm still okay to merge this in since it seems to be working for those. thoughts on what it could be?
(also tried again, still showed this screen but instead said the link was invalid or smt)
It's odd, I referenced the docs again and it mentioned to use the "PASSWORD_RECOVERY" event. However, I recall the events triggered were just "SIGNED_IN" or "INITIAL_SESSION"... It could've been that Supabase patched a bug or updated the functionality. I do remember the flow working before though. Nonetheless, I think the functionality this PR is intended to do is to fix the site URL determination code, which seems to be working (at least for localhost and preview). We should investigate the forgot password flow deeper as a separate issue. |
InayaY3
left a comment
InayaY3
left a comment
There was a problem hiding this comment.
will have to investigate the forgot password flow particularly on vercel previews, but otherwise LGTM
2 participants
What's new in this PR
Description
How to review
The nature of the feature requires testing after production. The site URL is determined as "http://localhost:3000/" if it detects it is not deployed by Vercel. If it is deployed in a preview environment by Vercel, the site URL will be the preview URL. If it is deployed in production, it will use the production URL.
For a complete test, the forgot password email link should be tested after this PR is merged.
Relevant links
CC: @ethan-tam33